Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-experimental): Add withActiveSpan #10194

Merged
merged 2 commits into from Jan 16, 2024
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 16, 2024

Adds withActiveSpan to the node-experimental package that will fork the current scope and set the provided span as active within the provided callback. Any startSpan calls within the callback will have the provided span as a child span.

We need this in situations where we need to pick up and create children for spans from a different execution context.

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@lforst lforst merged commit b397b39 into develop Jan 16, 2024
54 checks passed
@lforst lforst deleted the lforst-with-active-span branch January 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants