feat(replays): Add snapshot function to replay canvas integration #10066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
Jan 4, 2024
billyvg
force-pushed
the
fn/replay-canvas-integration
branch
from
66bc1a3
to
1044586
Compare
billyvg
changed the base branch from
fn/replay-canvas-integration
to
fn/replay-canvas-integration-sep-package
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
2 times, most recently
from
3e11d66
to
86ce591
Compare
c298lee
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 10, 2024
Adds a snapshot canvas function that allows you to manually snapshot canvas elements, which enables recording of 3d and webgl canvas Requires getsentry/sentry-javascript#10066
c298lee
force-pushed
the
snapshot-replay-canvas
branch
from
b23bf20
to
86ce591
Compare
Adding this integration in addition to `Replay` will set up canvas recording.
c298lee
force-pushed
the
snapshot-replay-canvas
branch
from
81606d9
to
c9136d5
Compare
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
from
b39c5fe
to
d001529
Compare
size-limit report 📦
|
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
2 times, most recently
from
03f872d
to
8f5257f
Compare
billyvg
reviewed
Jan 12, 2024
There was a problem hiding this comment.
We should add a test for this as well, I would look at https://github.com/getsentry/sentry-javascript/blob/fn/replay-canvas-integration-sep-package/dev-packages/browser-integration-tests/suites/replay/canvas/records/test.ts for an example
|
What's the context for this, actually? So, why/when would you do a manual canvas snapshot? |
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
from
8f5257f
to
cb20f6a
Compare
c298lee
force-pushed
the
snapshot-replay-canvas
branch
from
4832cda
to
301dbf4
Compare
billyvg
reviewed
Jan 16, 2024
dev-packages/browser-integration-tests/suites/replay/canvas/snapshots/init.js
Outdated
Show resolved
Hide resolved
dev-packages/browser-integration-tests/suites/replay/canvas/snapshots/test.ts
Outdated
Show resolved
Hide resolved
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
from
9dd8cfe
to
b87f421
Compare
Adding this integration in addition to `Replay` will set up canvas recording.
c298lee
force-pushed
the
snapshot-replay-canvas
branch
from
081dc39
to
bdb58a4
Compare
billyvg
approved these changes
Jan 17, 2024
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 26, 2024
Adds a snapshot canvas function that allows you to manually snapshot canvas elements, which enables recording of 3d and webgl canvas Requires getsentry/sentry-javascript#10066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a snapshot function that allows the user to manually snapshot canvas for gl/3d contexts. Manual snapshot will take a snapshot of the canvas element passed in or all canvas in the window if nothing is passed in.
To manually snapshot:
new Sentry.ReplayCanvas({ enableManualSnapshot:true })Sentry.getClient().getIntegrationByName('ReplayCanvas').snapshot();into your render/repaintCloses https://github.com/getsentry/team-replay/issues/308