Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): Add manual canvas snapshot function #149

Merged
merged 11 commits into from
Jan 10, 2024
Merged

Conversation

c298lee
Copy link
Member

@c298lee c298lee commented Jan 3, 2024

Adds a snapshot canvas function that allows you to manually snapshot canvas elements, which enables recording of 3d and webgl canvas

Requires getsentry/sentry-javascript#10066

@c298lee c298lee requested review from billyvg and a team January 3, 2024 22:25
Copy link

github-actions bot commented Jan 3, 2024

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.67 KB (+0.03% 🔺)
rrweb - record & CanvasManager only (gzipped) 19.32 KB (+0.57% 🔺)
rrweb - record only (min) 56.92 KB (+0.03% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.46 KB (+0.03% 🔺)

@c298lee c298lee changed the base branch from sentry-v2 to feat-fix-tree-shaking-canvas-manager January 9, 2024 19:41
@c298lee c298lee requested a review from billyvg January 9, 2024 19:43
@c298lee c298lee changed the base branch from feat-fix-tree-shaking-canvas-manager to sentry-v2 January 9, 2024 20:51
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but otherwise this looks great!

@c298lee c298lee requested review from billyvg and mydea January 9, 2024 23:15
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c298lee c298lee merged commit 2edc45b into sentry-v2 Jan 10, 2024
14 checks passed
@c298lee c298lee deleted the snapshot-canvas branch January 10, 2024 15:56
billyvg pushed a commit that referenced this pull request Apr 26, 2024
Adds a snapshot canvas function that allows you to manually snapshot
canvas elements, which enables recording of 3d and webgl canvas

Requires getsentry/sentry-javascript#10066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants