forked from rrweb-io/rrweb
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): Add manual canvas snapshot function #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
c298lee
commented
Jan 3, 2024
billyvg
reviewed
Jan 9, 2024
billyvg
reviewed
Jan 9, 2024
c298lee
changed the base branch from
sentry-v2
to
feat-fix-tree-shaking-canvas-manager
January 9, 2024 19:41
c298lee
changed the base branch from
feat-fix-tree-shaking-canvas-manager
to
sentry-v2
January 9, 2024 20:51
billyvg
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, but otherwise this looks great!
billyvg
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
billyvg
reviewed
Jan 9, 2024
billyvg
pushed a commit
that referenced
this pull request
Apr 26, 2024
Adds a snapshot canvas function that allows you to manually snapshot canvas elements, which enables recording of 3d and webgl canvas Requires getsentry/sentry-javascript#10066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a snapshot canvas function that allows you to manually snapshot canvas elements, which enables recording of 3d and webgl canvas
Requires getsentry/sentry-javascript#10066