fix(nextjs): Client code should not use Node global (#10925)

Found while working through ESM issues in #10833. For whatever reason this passes all the integration tests until ESM is used 🤯
getsentry · Mar 7, 2024 · f26f68c · f26f68c
1 parent ef59a91
commit f26f68c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/nextjs/src/client/rewriteFramesIntegration.ts b/packages/nextjs/src/client/rewriteFramesIntegration.ts
@@ -1,8 +1,9 @@
 import { defineIntegration } from '@sentry/core';
 import { rewriteFramesIntegration as originalRewriteFramesIntegration } from '@sentry/integrations';
 import type { IntegrationFn, StackFrame } from '@sentry/types';
+import { GLOBAL_OBJ } from '@sentry/utils';
 
-const globalWithInjectedValues = global as typeof global & {
+const globalWithInjectedValues = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
   __rewriteFramesAssetPrefixPath__: string;
 };
 

diff --git a/packages/nextjs/src/client/tunnelRoute.ts b/packages/nextjs/src/client/tunnelRoute.ts
@@ -1,9 +1,9 @@
 import type { BrowserOptions } from '@sentry/react';
-import { dsnFromString, logger } from '@sentry/utils';
+import { GLOBAL_OBJ, dsnFromString, logger } from '@sentry/utils';
 
 import { DEBUG_BUILD } from '../common/debug-build';
 
-const globalWithInjectedValues = global as typeof global & {
+const globalWithInjectedValues = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
   __sentryRewritesTunnelPath__?: string;
 };
 

diff --git a/packages/nextjs/src/server/rewriteFramesIntegration.ts b/packages/nextjs/src/server/rewriteFramesIntegration.ts
@@ -5,9 +5,9 @@ import {
   rewriteFramesIntegration as originalRewriteFramesIntegration,
 } from '@sentry/integrations';
 import type { IntegrationFn, StackFrame } from '@sentry/types';
-import { escapeStringForRegex } from '@sentry/utils';
+import { GLOBAL_OBJ, escapeStringForRegex } from '@sentry/utils';
 
-const globalWithInjectedValues = global as typeof global & {
+const globalWithInjectedValues = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
   __rewriteFramesDistDir__?: string;
 };