Skip to content

Commit

Permalink
fix(react): Warn and fall back gracefully if dependency injected func…
Browse files Browse the repository at this point in the history
…tions are not available (#12026)
  • Loading branch information
lforst committed May 14, 2024
1 parent d6cb302 commit c0753f0
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions packages/react/src/reactrouterv6.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,15 @@ export function wrapCreateBrowserRouter<
TState extends RouterState = RouterState,
TRouter extends Router<TState> = Router<TState>,
>(createRouterFunction: CreateRouterFunction<TState, TRouter>): CreateRouterFunction<TState, TRouter> {
if (!_useEffect || !_useLocation || !_useNavigationType || !_matchRoutes) {
DEBUG_BUILD &&
logger.warn(
'reactRouterV6Instrumentation was unable to wrap the `createRouter` function because of one or more missing parameters.',
);

return createRouterFunction;
}

// `opts` for createBrowserHistory and createMemoryHistory are different, but also not relevant for us at the moment.
// `basename` is the only option that is relevant for us, and it is the same for all.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down

0 comments on commit c0753f0

Please sign in to comment.