test: Add tests for removing unsampled transaction from scope

getsentry · Feb 1, 2021 · aa7b3c9 · aa7b3c9
1 parent f4ff847
commit aa7b3c9
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/packages/tracing/test/idletransaction.test.ts b/packages/tracing/test/idletransaction.test.ts
@@ -30,7 +30,7 @@ describe('IdleTransaction', () => {
       });
     });
 
-    it('removes transaction from scope on finish if onScope is true', () => {
+    it('removes sampled transaction from scope on finish if onScope is true', () => {
       const transaction = new IdleTransaction({ name: 'foo' }, hub, 1000, true);
       transaction.initSpanRecorder(10);
 
@@ -41,6 +41,17 @@ describe('IdleTransaction', () => {
         expect(s.getTransaction()).toBe(undefined);
       });
     });
+
+    it('removes unsampled transaction from scope on finish if onScope is true', () => {
+      const transaction = new IdleTransaction({ name: 'foo', sampled: false }, hub, 1000, true);
+
+      transaction.finish();
+      jest.runAllTimers();
+
+      hub.configureScope(s => {
+        expect(s.getTransaction()).toBe(undefined);
+      });
+    });
   });
 
   beforeEach(() => {