Skip to content

Commit

Permalink
chore(otel): Move Instrumenter type to @sentry/types
Browse files Browse the repository at this point in the history
  • Loading branch information
mydea committed Nov 3, 2022
1 parent 612b242 commit 8f593f9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
6 changes: 2 additions & 4 deletions packages/node/src/types.ts
@@ -1,9 +1,7 @@
import { ClientOptions, Options, TracePropagationTargets } from '@sentry/types';
import { ClientOptions, Instrumenter, Options, TracePropagationTargets } from '@sentry/types';

import { NodeTransportOptions } from './transports';

type SentryNodeInstrumenter = 'sentry' | 'otel';

export interface BaseNodeOptions {
/** Sets an optional server name (device name) */
serverName?: string;
Expand All @@ -28,7 +26,7 @@ export interface BaseNodeOptions {
*
* NOTE: Any option except for `sentry` is highly experimental and subject to change!
*/
instrumenter?: SentryNodeInstrumenter;
instrumenter?: Instrumenter;

/** Callback that is executed when a fatal global error occurs. */
onFatalError?(error: Error): void;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/index.ts
Expand Up @@ -92,3 +92,4 @@ export type {
} from './transport';
export type { User, UserFeedback } from './user';
export type { WrappedFunction } from './wrappedfunction';
export type { Instrumenter } from './instrumenter';
1 change: 1 addition & 0 deletions packages/types/src/instrumenter.ts
@@ -0,0 +1 @@
export type Instrumenter = 'sentry' | 'otel';

0 comments on commit 8f593f9

Please sign in to comment.