Skip to content

Commit

Permalink
fix(wasm): Add @sentry/core as a dependency (#10283)
Browse files Browse the repository at this point in the history
By using functional integrations in #10230, we started importing from
`@sentry/core` in the WASM integration. However, we didn't register
`@sentry/core` as a dependency, making rollup bundle core into the
package output. This changed the `build/npm` directory structure, making
our entry points in `package.json` invalid.

This PR fixes things by simply registering core as a dependency of wasm.
If we move WASM to core (which I strongly think we should do), we'll be
able to get rid of this again.
  • Loading branch information
Lms24 committed Jan 22, 2024
1 parent 5f0b506 commit 7e3207d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
- 'packages/replay/**'
- 'packages/replay-canvas/**'
- 'packages/feedback/**'
- 'packages/wasm/**'
browser_integration:
- *shared
- *browser
Expand Down
3 changes: 2 additions & 1 deletion packages/wasm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"dependencies": {
"@sentry/browser": "7.94.1",
"@sentry/types": "7.94.1",
"@sentry/utils": "7.94.1"
"@sentry/utils": "7.94.1",
"@sentry/core": "7.94.1"
},
"scripts": {
"build": "run-p build:transpile build:bundle build:types",
Expand Down

0 comments on commit 7e3207d

Please sign in to comment.