Misc code review comments added

getsentry · Sep 15, 2021 · 73480d5 · 73480d5
1 parent 50d4cae
commit 73480d5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/packages/browser/src/transports/fetch.ts b/packages/browser/src/transports/fetch.ts
@@ -163,6 +163,7 @@ export class FetchTransport extends BaseTransport {
           }),
       )
       .then(undefined, reason => {
+        // It's either buffer rejection or any other xhr/fetch error, which are treated as NetworkError.
         if (reason instanceof SentryError) {
           this.recordLostEvent(Outcome.QueueOverflow, sentryRequest.type);
         } else {

diff --git a/packages/browser/src/transports/xhr.ts b/packages/browser/src/transports/xhr.ts
@@ -64,6 +64,7 @@ export class XHRTransport extends BaseTransport {
           }),
       )
       .then(undefined, reason => {
+        // It's either buffer rejection or any other xhr/fetch error, which are treated as NetworkError.
         if (reason instanceof SentryError) {
           this.recordLostEvent(Outcome.QueueOverflow, sentryRequest.type);
         } else {

diff --git a/packages/types/src/transport.ts b/packages/types/src/transport.ts
@@ -65,7 +65,7 @@ export interface TransportOptions {
   fetchParameters?: { [key: string]: string };
   /** The envelope tunnel to use. */
   tunnel?: string;
-  /** Automatically send SDK Client Report */
+  /** Send SDK Client Reports. Enabled by default. */
   sendClientReports?: boolean;
   /**
    * Set of metadata about the SDK that can be internally used to enhance envelopes and events,