Skip to content

Commit

Permalink
remove outdated TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
Lms24 committed Nov 22, 2022
1 parent 7269e2f commit 4d3e188
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions packages/tracing/src/browser/request.ts
Expand Up @@ -143,8 +143,6 @@ export function instrumentOutgoingRequests(_options?: Partial<RequestInstrumenta
* A function that determines whether to attach tracing headers to a request.
* This was extracted from `instrumentOutgoingRequests` to make it easier to test shouldAttachHeaders.
* We only export this fuction for testing purposes.
*
* TODO (v8): Remove `tracingOrigins` which should drastically simplify this function.
*/
export function shouldAttachHeaders(url: string, tracePropagationTargets: (string | RegExp)[] | undefined): boolean {
return stringMatchesSomePattern(url, tracePropagationTargets || DEFAULT_TRACE_PROPAGATION_TARGETS);
Expand Down
1 change: 0 additions & 1 deletion packages/tracing/test/browser/request.test.ts
Expand Up @@ -391,7 +391,6 @@ describe('callbacks', () => {
});
});

// TODO (v8): Adapt these tests once we remove `tracingOrigins`
describe('shouldAttachHeaders', () => {
describe('should prefer `tracePropagationTargets` over defaults', () => {
it('should return `true` if the url matches the new tracePropagationTargets', () => {
Expand Down

0 comments on commit 4d3e188

Please sign in to comment.