Update protocol namings

getsentry · Sep 10, 2021 · 0e585c2 · 0e585c2
1 parent f5f0411
commit 0e585c2
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 18 deletions.
diff --git a/packages/browser/src/transports/fetch.ts b/packages/browser/src/transports/fetch.ts
@@ -113,7 +113,7 @@ export class FetchTransport extends BaseTransport {
    */
   private _sendRequest(sentryRequest: SentryRequest, originalPayload: Event | Session): PromiseLike<Response> {
     if (this._isRateLimited(sentryRequest.type)) {
-      this.recordLostEvent(Outcome.RateLimit, sentryRequest.type);
+      this.recordLostEvent(Outcome.RateLimitBackoff, sentryRequest.type);
 
       return Promise.reject({
         event: originalPayload,
@@ -164,7 +164,7 @@ export class FetchTransport extends BaseTransport {
       )
       .then(undefined, reason => {
         if (reason instanceof SentryError) {
-          this.recordLostEvent(Outcome.QueueSize, sentryRequest.type);
+          this.recordLostEvent(Outcome.QueueOverflow, sentryRequest.type);
         } else {
           this.recordLostEvent(Outcome.NetworkError, sentryRequest.type);
         }

diff --git a/packages/browser/src/transports/xhr.ts b/packages/browser/src/transports/xhr.ts
@@ -26,7 +26,7 @@ export class XHRTransport extends BaseTransport {
    */
   private _sendRequest(sentryRequest: SentryRequest, originalPayload: Event | Session): PromiseLike<Response> {
     if (this._isRateLimited(sentryRequest.type)) {
-      this.recordLostEvent(Outcome.RateLimit, sentryRequest.type);
+      this.recordLostEvent(Outcome.RateLimitBackoff, sentryRequest.type);
 
       return Promise.reject({
         event: originalPayload,
@@ -65,7 +65,7 @@ export class XHRTransport extends BaseTransport {
       )
       .then(undefined, reason => {
         if (reason instanceof SentryError) {
-          this.recordLostEvent(Outcome.QueueSize, sentryRequest.type);
+          this.recordLostEvent(Outcome.QueueOverflow, sentryRequest.type);
         } else {
           this.recordLostEvent(Outcome.NetworkError, sentryRequest.type);
         }

diff --git a/packages/browser/test/unit/transports/base.test.ts b/packages/browser/test/unit/transports/base.test.ts
@@ -49,7 +49,7 @@ describe('BaseTransport', () => {
       visibilityState = 'hidden';
       document.dispatchEvent(new Event('visibilitychange'));
 
-      const outcomes = [{ reason: 'before_send', category: 'error', quantity: 1 }];
+      const outcomes = [{ reason: Outcome.BeforeSend, category: 'error', quantity: 1 }];
 
       expect(sendBeaconSpy).toHaveBeenCalledWith(
         envelopeEndpoint,
@@ -75,16 +75,16 @@ describe('BaseTransport', () => {
       transport.recordLostEvent(Outcome.SampleRate, 'transaction');
       transport.recordLostEvent(Outcome.NetworkError, 'session');
       transport.recordLostEvent(Outcome.NetworkError, 'session');
-      transport.recordLostEvent(Outcome.RateLimit, 'event');
+      transport.recordLostEvent(Outcome.RateLimitBackoff, 'event');
 
       visibilityState = 'hidden';
       document.dispatchEvent(new Event('visibilitychange'));
 
       const outcomes = [
-        { reason: 'before_send', category: 'error', quantity: 2 },
-        { reason: 'sample_rate', category: 'transaction', quantity: 1 },
-        { reason: 'network_error', category: 'session', quantity: 2 },
-        { reason: 'rate_limit', category: 'error', quantity: 1 },
+        { reason: Outcome.BeforeSend, category: 'error', quantity: 2 },
+        { reason: Outcome.SampleRate, category: 'transaction', quantity: 1 },
+        { reason: Outcome.NetworkError, category: 'session', quantity: 2 },
+        { reason: Outcome.RateLimitBackoff, category: 'error', quantity: 1 },
       ];
 
       expect(sendBeaconSpy).toHaveBeenCalledWith(

diff --git a/packages/browser/test/unit/transports/fetch.test.ts b/packages/browser/test/unit/transports/fetch.test.ts
@@ -129,7 +129,7 @@ describe('FetchTransport', () => {
       try {
         await transport.sendEvent(transactionPayload);
       } catch (_) {
-        expect(spy).toHaveBeenCalledWith(Outcome.QueueSize, 'transaction');
+        expect(spy).toHaveBeenCalledWith(Outcome.QueueOverflow, 'transaction');
       }
     });
 
@@ -490,13 +490,13 @@ describe('FetchTransport', () => {
         try {
           await transport.sendEvent(eventPayload);
         } catch (_) {
-          expect(spy).toHaveBeenCalledWith(Outcome.RateLimit, 'event');
+          expect(spy).toHaveBeenCalledWith(Outcome.RateLimitBackoff, 'event');
         }
 
         try {
           await transport.sendEvent(transactionPayload);
         } catch (_) {
-          expect(spy).toHaveBeenCalledWith(Outcome.RateLimit, 'transaction');
+          expect(spy).toHaveBeenCalledWith(Outcome.RateLimitBackoff, 'transaction');
         }
       });
     });

diff --git a/packages/browser/test/unit/transports/xhr.test.ts b/packages/browser/test/unit/transports/xhr.test.ts
@@ -91,7 +91,7 @@ describe('XHRTransport', () => {
       try {
         await transport.sendEvent(transactionPayload);
       } catch (_) {
-        expect(spy).toHaveBeenCalledWith(Outcome.QueueSize, 'transaction');
+        expect(spy).toHaveBeenCalledWith(Outcome.QueueOverflow, 'transaction');
       }
     });
 
@@ -416,13 +416,13 @@ describe('XHRTransport', () => {
         try {
           await transport.sendEvent(eventPayload);
         } catch (_) {
-          expect(spy).toHaveBeenCalledWith(Outcome.RateLimit, 'event');
+          expect(spy).toHaveBeenCalledWith(Outcome.RateLimitBackoff, 'event');
         }
 
         try {
           await transport.sendEvent(transactionPayload);
         } catch (_) {
-          expect(spy).toHaveBeenCalledWith(Outcome.RateLimit, 'transaction');
+          expect(spy).toHaveBeenCalledWith(Outcome.RateLimitBackoff, 'transaction');
         }
       });
     });

diff --git a/packages/types/src/transport.ts b/packages/types/src/transport.ts
@@ -9,8 +9,8 @@ export enum Outcome {
   BeforeSend = 'before_send',
   EventProcessor = 'event_processor',
   NetworkError = 'network_error',
-  QueueSize = 'queue_size',
-  RateLimit = 'rate_limit',
+  QueueOverflow = 'queue_overflow',
+  RateLimitBackoff = 'ratelimit_backoff',
   SampleRate = 'sample_rate',
 }