Skip to content

fix(replay): Mask read-only TextField Composables #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 25, 2025

📜 Description

Newer versions of Compose seem to skip adding a SetText semantic entirely when a TextField is readOnly = true or enabled = false, so we fallback to the EditableText semantic which seems to be always present.

💡 Motivation and Context

Part of #4177
Internal customer case

💚 How did you test it?

Manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

romtsn added 5 commits April 24, 2025 15:34
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.08 ms 467.68 ms 61.60 ms
Size 1.58 MiB 2.08 MiB 507.73 KiB

Previous results on branch: rz/fix/session-replay-compose-readonly-text-masking

Startup times

Revision Plain With Sentry Diff
62e7f05 438.98 ms 503.63 ms 64.65 ms

App size

Revision Plain With Sentry Diff
62e7f05 1.58 MiB 2.08 MiB 507.57 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

Base automatically changed from rz/fix/session-replay-compose-text-nostyle-masking to main April 28, 2025 22:15
@romtsn romtsn enabled auto-merge (squash) April 28, 2025 22:17
@romtsn romtsn merged commit 02931bf into main Apr 28, 2025
37 of 38 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-compose-readonly-text-masking branch April 28, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants