Skip to content

Fix swallow NDK loadLibrary errors #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

markushi
Copy link
Member

@markushi markushi commented Jan 21, 2025

📜 Description

Restores the same behaviour we had in 7.x.x:

} catch (Throwable t) {
// ignored
// if loadLibrary() fails, the later init() will throw an exception anyway
} finally {

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 368.92 ms 424.00 ms 55.08 ms
Size 1.65 MiB 2.31 MiB 677.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: markushi/fix/swallow-ndk-preload-errors

Startup times

Revision Plain With Sentry Diff
7d5a80a 441.14 ms 472.39 ms 31.24 ms

App size

Revision Plain With Sentry Diff
7d5a80a 1.65 MiB 2.31 MiB 677.54 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you add this to the changelog, please make sure to duplicate the entry into the section at the bottom where we list all changes that happened since rc.4.

@markushi markushi merged commit fc52a26 into main Jan 21, 2025
39 checks passed
@markushi markushi deleted the markushi/fix/swallow-ndk-preload-errors branch January 21, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants