POTEL 63 - Let OpenTelemetry handle extracting and injecting tracing information #3953
+355
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a90f316.
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 592160f | 403.94 ms | 466.88 ms | 62.94 ms |
| f6fa4a0 | 398.98 ms | 408.94 ms | 9.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 592160f | 1.65 MiB | 2.31 MiB | 676.08 KiB |
| f6fa4a0 | 1.65 MiB | 2.31 MiB | 676.08 KiB |
Base automatically changed from
feat/build-propagation-context-from-sampling-decision
to
8.x.x
December 5, 2024 09:52
adinauer
deleted the
feat/disable-continue-trace-based-on-ignored-span-origins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use
ignoredSpanOriginsto also disable calls to.continueTraceand injecting tracing headers on outgoing calls.💡 Motivation and Context
When using OpenTelemetry and our Sentry integrations, we're overriding our OpenTelemetry integrations
PropagationContext. This is especially problematic when asentry-traceheader comes in with deferred sampling decision (neither-1nor-0suffix) and e.g. the Spring integrations overrides the sampling decision made bySentrySampler.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps