-
-
Notifications
You must be signed in to change notification settings - Fork 452
POTEL 55 - Fix startChild
for span that is not in current OTel Context
#3862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+281
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Loading status checks…
Loading status checks…
…or no agent
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 55 - Fix `startChild` for span that is not in current OTel `Context` ([#3862](https://github.com/getsentry/sentry-java/pull/3862)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
lbloder
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Loading status checks…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
OtelSpanFactory
now sets theOtelSpanWrapper
s underlying OTel span as current span in theContext
used when creating a new child span so theContext
that arrives in the span processor has the correct parent set.💡 Motivation and Context
Starting a child span from a transaction that wasn't in the current
Context
lead to multiple transactions being created (one for the transaction and another per span created).💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps