POTEL 51 - Cleanup OTel class loading #3848
Merged
+492
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 51 - Cleanup OTel class loading ([#3848](https://github.com/getsentry/sentry-java/pull/3848))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
lbloder
reviewed
Nov 8, 2024
| which causes OtelContextScopesStorage.init to register SentryContextStorage | ||
| as a wrapper. The wrapper can only be set until storage has been initialized by OpenTelemetry. | ||
| */ | ||
| Sentry.getGlobalScope(); |
There was a problem hiding this comment.
Hmm, should we create a more specific method in the Sentry class to make it clear that this method initalizes the storage?
There was a problem hiding this comment.
I think the extracted method plus the comment here should suffice and I'd rather not clutter public API with a noop method.
...ng-boot-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt
Show resolved
Hide resolved
...ng-boot-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt
Show resolved
Hide resolved
...ng-boot-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt
Show resolved
Hide resolved
Base automatically changed from
feat/spring-boot-autoconfig-for-otel-no-agent
to
8.x.x
November 11, 2024 14:53
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps