Fix faulty span.frame_delay calculation for early app start spans #3427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
The return value of
frameMetricsCollector.getLastKnownFrameStartTimeNanos()
was ignored, thus creating large frame delay values.I also moved data collection post initial
tracer.finish
, ensuring a finish timestamp is set and spans / txns are already trimmed. This is especially useful for idleui.load
transactions, as otherwise the frame delay will be longer than the txn duration.馃挕 Motivation and Context
馃挌 How did you test it?
馃摑 Checklist
sendDefaultPII
is enabled.馃敭 Next steps