Hubs/Scopes Merge 42d - Close previous scopes before binding a new global client #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
…ainScopes to rootScopes
adinauer
commented
May 2, 2024
| import kotlin.test.Test | ||
|
|
||
| class MetricsIntegrationTest { | ||
|
|
||
| @BeforeTest |
There was a problem hiding this comment.
Test started becoming flaky. Not sure why exactly.
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Hubs/Scopes Merge 42d - Close previous scopes before binding a new global client ([#3404](https://github.com/getsentry/sentry-java/pull/3404))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
lbloder
reviewed
May 3, 2024
| it.dsn = dsn | ||
| } | ||
| verify(scopes).close(eq(true)) | ||
| assertTrue(Sentry.getGlobalScope().client.isEnabled) |
There was a problem hiding this comment.
Should we also check that Sentry.getCurrentScopes() has an enabled client?
There was a problem hiding this comment.
We basically already are. It'd be more of a duplicate of tests already present in ScopesTest / CombinedScopeViewTest. I think it's fine as is.
lbloder
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
When calling
closeon the previous scopes after a new client has already been bound to the global scope, the new client is closed and Sentry does not capture events anymore.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps