Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed default deadline timeout to 30s instead of 300s #3322

Merged
merged 2 commits into from Apr 4, 2024

Conversation

stefanosiano
Copy link
Member

馃摐 Description

fixed default deadline timeout to 30s instead of 300s

馃挕 Motivation and Context

some transaction were kept alive for 5 minutes instead of 30 seconds

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review April 4, 2024 15:06
@stefanosiano stefanosiano enabled auto-merge (squash) April 4, 2024 15:10
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 404.94 ms 475.94 ms 71.00 ms
Size 1.70 MiB 2.28 MiB 592.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c3f503e 360.41 ms 434.67 ms 74.27 ms
a3c77bc 375.80 ms 445.85 ms 70.06 ms
baaf637 418.39 ms 496.86 ms 78.47 ms
c34791a 415.40 ms 498.22 ms 82.82 ms
d429384 393.79 ms 454.64 ms 60.85 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
4e29063 384.14 ms 447.74 ms 63.60 ms
28c9a83 416.98 ms 479.90 ms 62.92 ms
93a76ca 381.08 ms 459.22 ms 78.14 ms
0bd723b 395.44 ms 472.66 ms 77.22 ms

App size

Revision Plain With Sentry Diff
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
a3c77bc 1.72 MiB 2.29 MiB 577.53 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
c34791a 1.70 MiB 2.28 MiB 587.88 KiB
d429384 1.72 MiB 2.27 MiB 558.42 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
28c9a83 1.70 MiB 2.28 MiB 592.00 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB

@stefanosiano stefanosiano merged commit ab55b2c into main Apr 4, 2024
25 checks passed
@stefanosiano stefanosiano deleted the fix/transaction-deadline-timeout branch April 4, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants