Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle=8.6, AGP=8.3.0, kotlin=1.9.22, compose=1.5+ #3263

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

markushi
Copy link
Member

@markushi markushi commented Mar 11, 2024

📜 Description

An attempt to see what works / is broken, as well if this may resolves our stuck github runners.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6488520

@markushi markushi changed the title Bump Gradle=8.6, AGP=8.2.0, kotlin=1.9.22, compose=1.5.12 Bump Gradle=8.6, AGP=8.3.0, kotlin=1.9.22, compose=1.5+ Mar 15, 2024
Copy link
Contributor

github-actions bot commented Mar 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 400.60 ms 459.54 ms 58.95 ms
Size 2.27 MiB 2.65 MiB 382.98 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4e260b3 378.73 ms 454.18 ms 75.45 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
0bd723b 395.44 ms 472.66 ms 77.22 ms
7275aa8 422.39 ms 456.94 ms 34.55 ms
baaf637 375.71 ms 441.58 ms 65.87 ms
7eccfdb 366.98 ms 440.27 ms 73.29 ms
937879e 417.64 ms 550.45 ms 132.81 ms
9119d59 407.12 ms 509.64 ms 102.52 ms
93a76ca 378.48 ms 451.78 ms 73.30 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms

App size

Revision Plain With Sentry Diff
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
7275aa8 1.70 MiB 2.28 MiB 590.71 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
7eccfdb 1.72 MiB 2.27 MiB 556.93 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
9119d59 1.70 MiB 2.27 MiB 583.84 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB

Previous results on branch: feat/version-bumps

Startup times

Revision Plain With Sentry Diff
4dfbdc1 380.50 ms 452.00 ms 71.50 ms

App size

Revision Plain With Sentry Diff
4dfbdc1 2.27 MiB 2.65 MiB 382.76 KiB

@markushi markushi marked this pull request as ready for review March 18, 2024 09:38
CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we also should check what maven publications look like now, I think there were some changes with regards to that (maybe we have to update maven-publish-plugin).

And also check sentry-compose publication specifically as there's probably also some changes in kmp gradle plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants