Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry-native crashes (6.33.2-beta.1 hotfix release branch) #3049

Closed
wants to merge 7 commits into from

Conversation

markushi
Copy link
Member

馃摐 Description

This is a branch for releasing 6.33.2-beta.1, do not merge!

馃挕 Motivation and Context

Fixes #2955

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@markushi markushi changed the base branch from main to release/6.33.1 November 13, 2023 09:08
@markushi markushi changed the title Hotfix release Fix sentry-native crashes (6.33.2-beta.1 hotfix release branch) Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Fails
馃毇 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix sentry-native crashes (6.33.2-beta.1 hotfix release branch) ([#3049](https://github.com/getsentry/sentry-java/pull/3049))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 馃毇 dangerJS against 107d163

CHANGELOG.md Outdated
- Bump Native SDK from v0.6.6 to v0.6.7 ([#3048](https://github.com/getsentry/sentry-java/pull/3048))
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#067)
- [diff](https://github.com/getsentry/sentry-native/compare/0.6.6...0.6.7)
- This fixes SIGSEV, SIGABRT, SIGBUS crashes happening after/around the August Google Play System update, see [#2955](https://github.com/getsentry/sentry-java/issues/2955) for more details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: this could get lost in the Deps section, let's move this to ### Fixes and add a note that the fix comes in through sentry-native 0.6.7.

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 399.00 ms 422.41 ms 23.41 ms
Size 1.72 MiB 2.29 MiB 577.50 KiB

@markushi markushi changed the base branch from release/6.33.1 to main November 15, 2023 12:52
@markushi
Copy link
Member Author

Closing in favor of #3053

@markushi markushi closed this Nov 15, 2023
@markushi markushi deleted the fix/sentry-native-crashes branch November 15, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The number of Crashes and ANRs has increased
5 participants