Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing license headers #3003

Merged
merged 2 commits into from Oct 20, 2023
Merged

Add missing license headers #3003

merged 2 commits into from Oct 20, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Oct 20, 2023

#skip-changelog

馃摐 Description

Add missing license headers, or change them to adhere to the correct structure

馃挕 Motivation and Context

Closes #2619

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 389.49 ms 485.18 ms 95.69 ms
Size 1.72 MiB 2.29 MiB 576.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7e2fbc 377.85 ms 426.35 ms 48.50 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
0bf143e 368.35 ms 437.47 ms 69.12 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms

App size

Revision Plain With Sentry Diff
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
0bf143e 1.72 MiB 2.29 MiB 576.50 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB

Previous results on branch: rz/chore/add-license-headers

Startup times

Revision Plain With Sentry Diff
7cceaa2 414.71 ms 493.61 ms 78.90 ms

App size

Revision Plain With Sentry Diff
7cceaa2 1.72 MiB 2.29 MiB 576.50 KiB

@romtsn romtsn force-pushed the rz/chore/add-license-headers branch from e7aad64 to ec8d161 Compare October 20, 2023 10:06
@romtsn romtsn merged commit 86f0096 into main Oct 20, 2023
19 checks passed
@romtsn romtsn deleted the rz/chore/add-license-headers branch October 20, 2023 12:39
Comment on lines +2 to +4
* Adapted from https://github.com/FasterXML/jackson-databind/blob/c1e92435c6942386394a2a7733065bb047773107/src/test/java/com/fasterxml/jackson/databind/util/ISO8601UtilsTest.java
*
* Copyright (C) 2007-, Tatu Saloranta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is wrong; ISO8601UtilsTest.java was retroactively added to Gson by google/gson#1638 and is not based on jackson-databind's ISO8601UtilsTest.java.

(Please correct me if I am wrong though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add attribution and the text of their license at the top of the file
3 participants