Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set export flag on Android receivers on API 33+ #2990

Merged
merged 3 commits into from Oct 17, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

registerReceiver now sets the RECEIVER_NOT_EXPORTED flag on API 33+
updated SDK target version to 34

💡 Motivation and Context

Starting from Android 14, it is necessary to explicitly set the export behavior for runtime-registered broadcasts as described here.
Fixes #2986

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review October 16, 2023 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.94 ms 450.72 ms 76.78 ms
Size 1.72 MiB 2.29 MiB 576.51 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms

App size

Revision Plain With Sentry Diff
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB

Previous results on branch: fix/android14-register-receiver

Startup times

Revision Plain With Sentry Diff
6f92cb8 379.08 ms 450.43 ms 71.35 ms
9e9ca64 419.66 ms 526.68 ms 107.02 ms

App size

Revision Plain With Sentry Diff
6f92cb8 1.72 MiB 2.29 MiB 576.50 KiB
9e9ca64 1.72 MiB 2.29 MiB 576.50 KiB

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...in/java/io/sentry/android/core/DeviceInfoUtil.java 53.53% <100.00%> (ø)
...droid/core/SystemEventsBreadcrumbsIntegration.java 85.84% <100.00%> (ø)
...main/java/io/sentry/android/core/ContextUtils.java 67.20% <50.00%> (-0.57%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides a couple of comments 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to initialize SystemEventsBreadcrumbsIntegration when starting sentry
2 participants