New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set export flag on Android receivers on API 33+ #2990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated SDK target version to 34
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
October 16, 2023 16:47
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c7e2fbc | 393.98 ms | 478.24 ms | 84.27 ms |
4bf95dd | 345.96 ms | 414.24 ms | 68.28 ms |
c7e2fbc | 372.00 ms | 461.71 ms | 89.71 ms |
99a51e2 | 405.11 ms | 479.65 ms | 74.54 ms |
c7e2fbc | 398.35 ms | 468.52 ms | 70.17 ms |
c7e2fbc | 377.85 ms | 426.35 ms | 48.50 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
4bf95dd | 1.72 MiB | 2.29 MiB | 576.40 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
99a51e2 | 1.72 MiB | 2.29 MiB | 576.34 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
romtsn
reviewed
Oct 17, 2023
sentry-android-core/src/main/java/io/sentry/android/core/ContextUtils.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 17, 2023
sentry-android-core/src/test/java/io/sentry/android/core/ContextUtilsUnitTests.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, besides a couple of comments 👍
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
registerReceiver now sets the RECEIVER_NOT_EXPORTED flag on API 33+
updated SDK target version to 34
💡 Motivation and Context
Starting from Android 14, it is necessary to explicitly set the export behavior for runtime-registered broadcasts as described here.
Fixes #2986
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps