New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRONS support for Quartz and Spring @Scheduled
#2952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
September 25, 2023 12:52
lbloder
approved these changes
Sep 25, 2023
lbloder
approved these changes
Sep 25, 2023
|
…the monitor slug per quartz trigger (#2948)
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f274c79 | 334.86 ms | 348.54 ms | 13.68 ms |
9e60fc1 | 310.37 ms | 359.48 ms | 49.11 ms |
9e60fc1 | 309.74 ms | 362.30 ms | 52.56 ms |
adf8fe3 | 300.49 ms | 357.36 ms | 56.87 ms |
9e60fc1 | 331.71 ms | 374.28 ms | 42.57 ms |
f60279b | 324.60 ms | 345.33 ms | 20.73 ms |
f274c79 | 313.96 ms | 355.96 ms | 42.00 ms |
fe10f05 | 314.71 ms | 360.62 ms | 45.90 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
695d3a3 | 300.98 ms | 376.90 ms | 75.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
adf8fe3 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
f60279b | 1.72 MiB | 2.29 MiB | 575.23 KiB |
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
695d3a3 | 1.72 MiB | 2.29 MiB | 575.53 KiB |
Previous results on branch: feat/crons-lib-support
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5894625 | 378.40 ms | 424.38 ms | 45.98 ms |
bc5c321 | 360.23 ms | 438.00 ms | 77.77 ms |
375e92a | 411.15 ms | 478.15 ms | 67.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5894625 | 1.72 MiB | 2.29 MiB | 575.99 KiB |
bc5c321 | 1.72 MiB | 2.29 MiB | 575.99 KiB |
375e92a | 1.72 MiB | 2.29 MiB | 575.99 KiB |
adinauer
changed the title
CRONS library support
CRONS support for Quartz and Spring Sep 27, 2023
@Scheduled
Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR collects mulitple PRs around CRONS to be merged into
main
together.Adds support for Quartz by providing a
SentryJobListener
that picks up the monitor slug from the job data map and sends check-ins for jobs where a slug is configured.Adds support for Spring
@Scheduled
tasks by annotating the task method with@SentryCheckIn
to configure the monitor slug.Also adds an option
ignoredCheckIns
to ignore check-ins for certain monitor slugs.💡 Motivation and Context
Closes #2875
💚 How did you test it?
Manually, partial Test coverage
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps