Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for ignoring certain monitor slugs #2943

Merged
merged 25 commits into from Sep 25, 2023

Conversation

adinauer
Copy link
Member

📜 Description

Add the following options:

  • enableAutomaticCheckIns which enables automatic Check-ins, e.g. Quartz; defaults to false meaning it's disabled
  • ignoredCheckIns which can be used to set a list of monitor slugs and regular expressions matching on the Check-ins monitor slug. These will then be dropped in SentryClient.

💡 Motivation and Context

Opt-in to automatic check-ins and a way to filter check-ins.

💚 How did you test it?

Manually + unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add option for ignoring certain monitor slugs ([#2943](https://github.com/getsentry/sentry-java/pull/2943))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 15d9388

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 610.22 ms 738.40 ms 128.18 ms
Size 1.72 MiB 2.29 MiB 576.11 KiB

Previous results on branch: feat/crons-options

Startup times

Revision Plain With Sentry Diff
6ed3382 326.87 ms 384.59 ms 57.71 ms
025e762 308.65 ms 348.98 ms 40.33 ms
3bb19ba 369.70 ms 487.59 ms 117.89 ms

App size

Revision Plain With Sentry Diff
6ed3382 1.72 MiB 2.29 MiB 576.11 KiB
025e762 1.72 MiB 2.29 MiB 576.11 KiB
3bb19ba 1.72 MiB 2.29 MiB 576.11 KiB

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head c420272 differs from pull request most recent head 15d9388. Consider uploading reports for the commit 15d9388 to get more accurate results

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, LGTM otherwise 👍

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer self-assigned this Sep 25, 2023
Base automatically changed from feat/crons-quartz to feat/crons-lib-support September 25, 2023 12:25
@adinauer adinauer changed the title Add options for opting into automatic checkins and ignoring certain monitor slugs Add option for ignoring certain monitor slugs Sep 25, 2023
@adinauer adinauer merged commit 7da0892 into feat/crons-lib-support Sep 25, 2023
11 of 14 checks passed
@adinauer adinauer deleted the feat/crons-options branch September 25, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants