Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send db.system and db.name in span data for androidx.sqlite spans #2928

Merged
merged 2 commits into from Sep 12, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Sep 11, 2023

馃摐 Description

  • Send db.system and db.name in span data for androidx.sqlite spans

image

馃挕 Motivation and Context

Closes #2893

馃挌 How did you test it?

Manually on the SAGP repo

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 310.10 ms 364.82 ms 54.72 ms
Size 1.72 MiB 2.29 MiB 575.94 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4bf202b 364.28 ms 419.66 ms 55.38 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
3baa73f 267.45 ms 388.30 ms 120.85 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
9e60fc1 310.00 ms 364.42 ms 54.42 ms
549cbb4 332.89 ms 384.44 ms 51.55 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms
4bf202b 331.20 ms 345.24 ms 14.04 ms
fb296f0 340.61 ms 394.88 ms 54.27 ms
0f34a0c 321.75 ms 377.68 ms 55.93 ms

App size

Revision Plain With Sentry Diff
4bf202b 1.72 MiB 2.29 MiB 575.54 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
3baa73f 1.72 MiB 2.29 MiB 575.52 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
9e60fc1 1.72 MiB 2.29 MiB 575.91 KiB
549cbb4 1.72 MiB 2.29 MiB 575.74 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
4bf202b 1.72 MiB 2.29 MiB 575.54 KiB
fb296f0 1.72 MiB 2.29 MiB 575.70 KiB
0f34a0c 1.72 MiB 2.29 MiB 575.74 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@romtsn romtsn merged commit a1ec71e into main Sep 12, 2023
18 of 19 checks passed
@romtsn romtsn deleted the rz/feat/starfish-db-attrs branch September 12, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Starfish] Add db attributes to database span's span data
2 participants