Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send-modules option #2926

Merged
merged 9 commits into from Sep 11, 2023
Merged

Conversation

evmetatron
Copy link
Contributor

@evmetatron evmetatron commented Sep 8, 2023

馃摐 Description

A new option to disable sending modules.

馃挕 Motivation and Context

I saw this option is in ruby options, but this option is not present in java options.
This option can be useful when you don't need to send a list of modules with versions.
When using sentry-spring-boot-starter you can use this option in application.yaml

馃挌 How did you test it?

I tested it using spring boot app

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've applied formatting and added the Option for Android Manifest. I'd like to give our Android specialists a chance to review this before approving and merging as this new option is useful for all SDK users.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adinauer adinauer merged commit 3cda41b into getsentry:main Sep 11, 2023
19 checks passed
@adinauer adinauer linked an issue Sep 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option send-modules to SentryOptions
3 participants