Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configureScope instead of withScope for InternalSentrySdk #2863

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

markushi
Copy link
Member

馃挕 Motivation and Context

Fixes #2814 (comment)

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 295.61 ms 355.67 ms 60.06 ms
Size 1.72 MiB 2.29 MiB 575.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0c08e7 310.28 ms 350.68 ms 40.40 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
f274c79 313.96 ms 355.96 ms 42.00 ms
dc67004 273.86 ms 346.37 ms 72.51 ms
f60279b 324.60 ms 345.33 ms 20.73 ms
f274c79 334.86 ms 348.54 ms 13.68 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
3baa73f 267.45 ms 388.30 ms 120.85 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
c03a05e 390.40 ms 419.35 ms 28.94 ms

App size

Revision Plain With Sentry Diff
d0c08e7 1.72 MiB 2.29 MiB 574.68 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
dc67004 1.72 MiB 2.28 MiB 573.45 KiB
f60279b 1.72 MiB 2.29 MiB 575.23 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
3baa73f 1.72 MiB 2.29 MiB 575.52 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
c03a05e 1.72 MiB 2.29 MiB 574.43 KiB

@kahest kahest requested a review from marandaneto July 24, 2023 14:38
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Looking forward for the release 馃殌

@markushi markushi merged commit f60cce2 into main Jul 25, 2023
20 checks passed
@markushi markushi deleted the fix/with-scope branch July 25, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants