Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up some transaction methods #2701

Merged
merged 10 commits into from May 10, 2023
Merged

Open up some transaction methods #2701

merged 10 commits into from May 10, 2023

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented May 5, 2023

📜 Description

Open up some transaction methods, so that they can be used from outside sentry
Add new startChild method to set timestamp

💡 Motivation and Context

Fixes #2640

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f8d3e91

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 345.55 ms 454.82 ms 109.27 ms
Size 1.72 MiB 2.28 MiB 565.45 KiB

Previous results on branch: feat/public-transaction-methods

Startup times

Revision Plain With Sentry Diff
2a22604 291.21 ms 342.83 ms 51.62 ms
1212d48 419.29 ms 484.16 ms 64.88 ms
b91be82 345.02 ms 365.88 ms 20.86 ms
3b09b8a 323.26 ms 369.64 ms 46.38 ms

App size

Revision Plain With Sentry Diff
2a22604 1.72 MiB 2.28 MiB 565.45 KiB
1212d48 1.72 MiB 2.28 MiB 565.45 KiB
b91be82 1.72 MiB 2.28 MiB 565.45 KiB
3b09b8a 1.72 MiB 2.28 MiB 565.45 KiB

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (ba90bd9) 81.05% compared to head (f8d3e91) 81.07%.

❗ Current head f8d3e91 differs from pull request most recent head 9ad6634. Consider uploading reports for the commit 9ad6634 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2701      +/-   ##
============================================
+ Coverage     81.05%   81.07%   +0.02%     
- Complexity     4427     4432       +5     
============================================
  Files           345      345              
  Lines         16356    16358       +2     
  Branches       2219     2219              
============================================
+ Hits          13258    13263       +5     
+ Misses         2170     2167       -3     
  Partials        928      928              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/IHub.java 92.59% <ø> (ø)
sentry/src/main/java/io/sentry/Sentry.java 83.55% <ø> (ø)
...ry/src/main/java/io/sentry/TransactionOptions.java 88.00% <ø> (ø)
...entry/src/main/java/io/sentry/NoOpTransaction.java 32.65% <100.00%> (+7.65%) ⬆️
sentry/src/main/java/io/sentry/SentryTracer.java 94.44% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbloder
Copy link
Collaborator Author

lbloder commented May 10, 2023

Hey @romtsn,
Thanks for reviewing.

I missed removing the @ApiStatus.Internal annotation from the TransactionOptions class, which I have done now and also added javadoc comments to it. Do you mind having another quick glance?

Thanks

@lbloder lbloder marked this pull request as ready for review May 10, 2023 15:12
CHANGELOG.md Outdated Show resolved Hide resolved
@romtsn romtsn enabled auto-merge (squash) May 10, 2023 20:13
@romtsn
Copy link
Member

romtsn commented May 10, 2023

looks good, thanks @lbloder !

@romtsn romtsn merged commit e96a1b7 into main May 10, 2023
11 of 13 checks passed
@romtsn romtsn deleted the feat/public-transaction-methods branch May 10, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open up Transaction Factory methods
3 participants