Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism for logging integrations and update spring mechanism types #2595

Merged
merged 5 commits into from Mar 15, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 9, 2023

📜 Description

When capturing an exception via any of our logging integrations (logback, log4j2, jul) we now add the mechanism and set the mechanism type.

💡 Motivation and Context

Fixes #2555

💚 How did you test it?

Unit tests, manually

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add mechanism for logging integrations and update spring mechanism types ([#2595](https://github.com/getsentry/sentry-java/pull/2595))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 0c804a9

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 270.22 ms 329.04 ms 58.82 ms
Size 1.73 MiB 2.34 MiB 626.68 KiB

Previous results on branch: feat/add-mechanism-and-update-spring-mechanisms

Startup times

Revision Plain With Sentry Diff
cb9f7b4 372.08 ms 388.64 ms 16.56 ms
9adeac7 332.47 ms 383.30 ms 50.83 ms
6793542 319.52 ms 397.06 ms 77.54 ms

App size

Revision Plain With Sentry Diff
cb9f7b4 1.73 MiB 2.34 MiB 626.25 KiB
9adeac7 1.73 MiB 2.34 MiB 626.46 KiB
6793542 1.73 MiB 2.34 MiB 626.68 KiB

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (46f5dfd) 81.16% compared to head (0c804a9) 81.21%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2595      +/-   ##
============================================
+ Coverage     81.16%   81.21%   +0.05%     
- Complexity     4149     4152       +3     
============================================
  Files           335      335              
  Lines         15432    15444      +12     
  Branches       2011     2011              
============================================
+ Hits          12525    12543      +18     
+ Misses         2111     2108       -3     
+ Partials        796      793       -3     
Impacted Files Coverage Δ
...sentry/spring/jakarta/SentryExceptionResolver.java 100.00% <ø> (ø)
...java/io/sentry/spring/SentryExceptionResolver.java 100.00% <ø> (ø)
...jul/src/main/java/io/sentry/jul/SentryHandler.java 78.16% <100.00%> (+2.08%) ⬆️
...src/main/java/io/sentry/log4j2/SentryAppender.java 87.27% <100.00%> (+2.36%) ⬆️
...rc/main/java/io/sentry/logback/SentryAppender.java 91.74% <100.00%> (+2.21%) ⬆️
...ing/jakarta/webflux/SentryWebExceptionHandler.java 92.30% <100.00%> (ø)
...ntry/spring/webflux/SentryWebExceptionHandler.java 94.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Show resolved Hide resolved
@adinauer adinauer marked this pull request as ready for review March 15, 2023 05:25
@adinauer adinauer merged commit af5051f into main Mar 15, 2023
@adinauer adinauer deleted the feat/add-mechanism-and-update-spring-mechanisms branch March 15, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mechanism when capturing exceptions from integrations
2 participants