New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism for logging integrations and update spring mechanism types #2595
Add mechanism for logging integrations and update spring mechanism types #2595
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add mechanism for logging integrations and update spring mechanism types ([#2595](https://github.com/getsentry/sentry-java/pull/2595)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cb9f7b4 | 372.08 ms | 388.64 ms | 16.56 ms |
9adeac7 | 332.47 ms | 383.30 ms | 50.83 ms |
6793542 | 319.52 ms | 397.06 ms | 77.54 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cb9f7b4 | 1.73 MiB | 2.34 MiB | 626.25 KiB |
9adeac7 | 1.73 MiB | 2.34 MiB | 626.46 KiB |
6793542 | 1.73 MiB | 2.34 MiB | 626.68 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
============================================
+ Coverage 81.16% 81.21% +0.05%
- Complexity 4149 4152 +3
============================================
Files 335 335
Lines 15432 15444 +12
Branches 2011 2011
============================================
+ Hits 12525 12543 +18
+ Misses 2111 2108 -3
+ Partials 796 793 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
📜 Description
When capturing an exception via any of our logging integrations (logback, log4j2, jul) we now add the mechanism and set the mechanism type.
💡 Motivation and Context
Fixes #2555
💚 How did you test it?
Unit tests, manually
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps