Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out session cookies sent by Spring and Spring Boot integrations #2593

Merged
merged 6 commits into from Mar 14, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 8, 2023

📜 Description

Replace values of certain cookies that could allow impersonation with [Filtered] and do not send the value to Sentry.

💡 Motivation and Context

Fixes #2562

💚 How did you test it?

Unit Tests, manually using samples

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8a58792

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 358.29 ms 398.90 ms 40.61 ms
Size 1.73 MiB 2.34 MiB 626.68 KiB

Previous results on branch: feat/filter-security-cookies

Startup times

Revision Plain With Sentry Diff
3594006 318.10 ms 351.82 ms 33.72 ms
0bd502c 320.20 ms 358.28 ms 38.08 ms
8e355e3 340.98 ms 408.76 ms 67.78 ms
f74c07d 331.85 ms 367.37 ms 35.52 ms
d824f03 297.43 ms 371.58 ms 74.15 ms

App size

Revision Plain With Sentry Diff
3594006 1.73 MiB 2.34 MiB 626.46 KiB
0bd502c 1.73 MiB 2.34 MiB 626.25 KiB
8e355e3 1.73 MiB 2.34 MiB 626.46 KiB
f74c07d 1.73 MiB 2.34 MiB 626.25 KiB
d824f03 1.73 MiB 2.34 MiB 626.46 KiB

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 75.18% and project coverage change: -0.01 ⚠️

Comparison is base (25e36a7) 81.17% compared to head (8a58792) 81.16%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2593      +/-   ##
============================================
- Coverage     81.17%   81.16%   -0.01%     
- Complexity     4102     4125      +23     
============================================
  Files           333      333              
  Lines         15213    15329     +116     
  Branches       1980     1995      +15     
============================================
+ Hits          12349    12442      +93     
- Misses         2084     2101      +17     
- Partials        780      786       +6     
Impacted Files Coverage Δ
.../spring/jakarta/webflux/SentryRequestResolver.java 67.85% <45.45%> (-3.58%) ⬇️
...o/sentry/spring/webflux/SentryRequestResolver.java 67.85% <45.45%> (-3.58%) ⬇️
...o/sentry/spring/jakarta/SentryRequestResolver.java 83.67% <75.75%> (-11.33%) ⬇️
...n/java/io/sentry/spring/SentryRequestResolver.java 83.67% <75.75%> (-11.33%) ⬇️
sentry/src/main/java/io/sentry/util/HttpUtils.java 84.78% <88.09%> (+84.78%) ⬆️
sentry/src/main/java/io/sentry/util/UrlUtils.java 91.13% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an observation, feel free to ignore

@adinauer adinauer merged commit 674b462 into main Mar 14, 2023
@adinauer adinauer deleted the feat/filter-security-cookies branch March 14, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Session Cookies sent by SDK
2 participants