-
-
Notifications
You must be signed in to change notification settings - Fork 452
Leave inApp flag for stack frames undecided in SDK if unsure and let ingestion decide instead #2547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leave inApp flag for stack frames undecided in SDK if unsure and let ingestion decide instead #2547
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b32504 | 315.69 ms | 373.96 ms | 58.27 ms |
754021c | 358.70 ms | 361.98 ms | 3.28 ms |
c1399c1 | 345.06 ms | 385.49 ms | 40.43 ms |
5fa24ec | 326.29 ms | 384.53 ms | 58.24 ms |
fe30606 | 310.82 ms | 335.36 ms | 24.55 ms |
f6a135d | 263.96 ms | 383.59 ms | 119.63 ms |
14c083a | 350.82 ms | 388.86 ms | 38.04 ms |
4b32504 | 357.14 ms | 404.04 ms | 46.90 ms |
fe30606 | 327.46 ms | 351.74 ms | 24.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b32504 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
754021c | 1.73 MiB | 2.33 MiB | 623.06 KiB |
c1399c1 | 1.73 MiB | 2.33 MiB | 620.61 KiB |
5fa24ec | 1.73 MiB | 2.33 MiB | 620.61 KiB |
fe30606 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
f6a135d | 1.73 MiB | 2.33 MiB | 623.10 KiB |
14c083a | 1.73 MiB | 2.33 MiB | 620.61 KiB |
4b32504 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
fe30606 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
Codecov ReportBase: 80.27% // Head: 80.27% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2547 +/- ##
=========================================
Coverage 80.27% 80.27%
+ Complexity 3986 3985 -1
=========================================
Files 327 327
Lines 15010 15010
Branches 1977 1977
=========================================
Hits 12050 12050
Misses 2183 2183
Partials 777 777
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📜 Description
If a stack frame neither matches any
inAppIncludes
norinAppExcludes
, we now treat it as undecided by settingnull
and leaving the decision to the backend / ingestion.💡 Motivation and Context
As discussed internally SDKs should only set
true
/false
if they're certain.💚 How did you test it?
Unit Tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps