Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassNotFoundException for io.sentry.spring.SentrySpringServletContainerInitializer in sentry-spring-jakarta #2413

Merged

Conversation

js361014
Copy link
Contributor

@js361014 js361014 commented Dec 4, 2022

📜 Description

💡 Motivation and Context

Fixes #2411

💚 How did you test it?

📝 Checklist

  • [ x] I reviewed the submitted code
  • I added tests to verify the changes
  • [x ] I updated the docs if needed
  • [ x] No breaking changes

🔮 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @js361014 for the help. I've added a changelog and also fixed the sample. It worked for me now when testing locally.

@adinauer adinauer changed the title Fixes jakarta.servlet.ServletContainerInitializer (#2411) - Fix ClassNotFoundException for io.sentry.spring.SentrySpringServletContainerInitializer in sentry-spring-jakarta Dec 5, 2022
@adinauer adinauer changed the title - Fix ClassNotFoundException for io.sentry.spring.SentrySpringServletContainerInitializer in sentry-spring-jakarta Fix ClassNotFoundException for io.sentry.spring.SentrySpringServletContainerInitializer in sentry-spring-jakarta Dec 5, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 80.03% // Head: 80.03% // No change to project coverage 👍

Coverage data is based on head (4d8f8f8) compared to base (ecf9680).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2413   +/-   ##
=========================================
  Coverage     80.03%   80.03%           
  Complexity     3765     3765           
=========================================
  Files           301      301           
  Lines         14207    14207           
  Branches       1884     1884           
=========================================
  Hits          11371    11371           
  Misses         2092     2092           
  Partials        744      744           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer merged commit f122116 into getsentry:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassNotFoundException: io.sentry.spring.SentrySpringServletContainerInitializer
3 participants