Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SENTRY_AUTO_INIT environment variable to control OpenTelemetry Agent init #2410

Merged
merged 6 commits into from Dec 6, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 2, 2022

📜 Description

Add SENTRY_AUTO_INIT environment variable to control OpenTelemetry Agent init.

💡 Motivation and Context

If a user provides SENTRY_DSN or SENTRY_PROPERTIES_FILE environment variables but intends to use Sentry.init in the target application this allows them to turn off auto init by the Sentry OpenTelemetry Java Agent.

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 244d54e

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 292.46 ms 333.00 ms 40.54 ms
Size 1.73 MiB 2.32 MiB 612.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1e1ab7f 383.48 ms 441.37 ms 57.89 ms
90e9745 314.68 ms 357.28 ms 42.60 ms
81a1a6c 294.04 ms 341.19 ms 47.15 ms
81a1a6c 328.73 ms 421.28 ms 92.55 ms
4a9c176 320.62 ms 334.68 ms 14.06 ms
3695453 314.63 ms 353.10 ms 38.47 ms
a04f788 321.78 ms 354.12 ms 32.35 ms
31f3e4c 325.22 ms 342.77 ms 17.55 ms
ecf9680 326.55 ms 360.26 ms 33.71 ms
ecf9680 321.55 ms 385.52 ms 63.97 ms

App size

Revision Plain With Sentry Diff
1e1ab7f 1.73 MiB 2.32 MiB 612.36 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB
81a1a6c 1.73 MiB 2.32 MiB 612.47 KiB
81a1a6c 1.73 MiB 2.32 MiB 612.47 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
a04f788 1.73 MiB 2.32 MiB 609.88 KiB
31f3e4c 1.73 MiB 2.32 MiB 612.47 KiB
ecf9680 1.73 MiB 2.32 MiB 612.39 KiB
ecf9680 1.73 MiB 2.32 MiB 612.39 KiB

Previous results on branch: feat/allow-turning-off-auto-init-in-otel-agent

Startup times

Revision Plain With Sentry Diff
fd9d617 319.02 ms 351.73 ms 32.71 ms
fe38665 278.45 ms 324.78 ms 46.33 ms
10bb0b0 305.47 ms 334.56 ms 29.09 ms
961331f 284.29 ms 341.83 ms 57.54 ms

App size

Revision Plain With Sentry Diff
fd9d617 1.73 MiB 2.32 MiB 612.36 KiB
fe38665 1.73 MiB 2.32 MiB 612.44 KiB
10bb0b0 1.73 MiB 2.32 MiB 612.39 KiB
961331f 1.73 MiB 2.32 MiB 612.44 KiB

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Base: 80.03% // Head: 80.03% // No change to project coverage 👍

Coverage data is based on head (2d1a223) compared to base (34a8bfd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2410   +/-   ##
=========================================
  Coverage     80.03%   80.03%           
  Complexity     3765     3765           
=========================================
  Files           301      301           
  Lines         14207    14207           
  Branches       1884     1884           
=========================================
  Hits          11371    11371           
  Misses         2092     2092           
  Partials        744      744           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer mentioned this pull request Dec 5, 2022
21 tasks
@adinauer adinauer merged commit 96b948d into main Dec 6, 2022
@adinauer adinauer deleted the feat/allow-turning-off-auto-init-in-otel-agent branch December 6, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants