Add OTEL propagator #2380
Merged
Add OTEL propagator #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spanId for Sentry instead of creating a new one
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
Performance metrics 🚀
|
This was referenced Nov 21, 2022
romtsn
approved these changes
Nov 25, 2022
| @@ -131,7 +131,8 @@ private ITransaction startTransaction( | |||
| TransactionNameSource.URL, | |||
| "http.server", | |||
| new SentryTraceHeader(sentryTraceHeader), | |||
| baggage); | |||
| baggage, | |||
| null); | |||
There was a problem hiding this comment.
shouldn't this be covered by the method overload without spanId?
There was a problem hiding this comment.
I added another param (spanId) to it. The other overload doesn't have baggage so can't be used here. I didn't want to introduce yet another overload for something that's only used internally anyways. Eventually I'd like to improve this by e.g. introducing a param object that has defaults which can be overriden.
AbhiPrasad
approved these changes
Nov 28, 2022
Yes, indeed. It hurts a little to have not tests yet 😢 . Was already on my list of next things to do. Added it as explicit item to #2327 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Add
SentryPropagator, register it and use it by default in the Sentry Java Agent JAR.💡 Motivation and Context
Continue traces (via
sentry-traceandbaggageheaders) by extracting headers from incoming requests and using that info for Span/Transaction creating as well as injecting headers into outgoing requests.💚 How did you test it?
Manually
📝 Checklist
🔮 Next steps