Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corrupted UUID on Motorola devices #2363

Merged
merged 2 commits into from Nov 15, 2022
Merged

Fix corrupted UUID on Motorola devices #2363

merged 2 commits into from Nov 15, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 15, 2022

📜 Description

We tested it with Bruno and indeed it returns a corrupted UUID on his device, no matter which method is used to instantiate the UUID:
image

So this is just a band aid for those cases

💡 Motivation and Context

Closes #2325

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 326.02 ms 406.00 ms 79.98 ms
Size 1.73 MiB 2.32 MiB 609.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f809aac 301.51 ms 346.60 ms 45.09 ms
a04f788 321.78 ms 354.12 ms 32.35 ms
7597ded 289.60 ms 339.69 ms 50.09 ms
90e9745 314.68 ms 357.28 ms 42.60 ms
38e4f11 358.20 ms 433.73 ms 75.53 ms

App size

Revision Plain With Sentry Diff
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
a04f788 1.73 MiB 2.32 MiB 609.88 KiB
7597ded 1.73 MiB 2.32 MiB 609.88 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB
38e4f11 1.73 MiB 2.32 MiB 609.82 KiB

Previous results on branch: fix/motorola-nil-uuid

Startup times

Revision Plain With Sentry Diff
7c64021 326.98 ms 359.85 ms 32.87 ms

App size

Revision Plain With Sentry Diff
7c64021 1.73 MiB 2.32 MiB 609.95 KiB

@codecov-commenter
Copy link

Codecov Report

Base: 80.29% // Head: 80.31% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (a99c362) compared to base (be45a71).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a99c362 differs from pull request most recent head b00e86b. Consider uploading reports for the commit b00e86b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2363      +/-   ##
============================================
+ Coverage     80.29%   80.31%   +0.02%     
- Complexity     3669     3672       +3     
============================================
  Files           290      290              
  Lines         13724    13727       +3     
  Branches       1809     1809              
============================================
+ Hits          11019    11025       +6     
+ Misses         2006     2005       -1     
+ Partials        699      697       -2     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SpanId.java 88.88% <100.00%> (ø)
...try/src/main/java/io/sentry/protocol/SentryId.java 93.54% <100.00%> (ø)
...ntry/src/main/java/io/sentry/util/StringUtils.java 85.36% <100.00%> (+1.15%) ⬆️
...try/src/main/java/io/sentry/CircularFifoQueue.java 39.02% <0.00%> (+2.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn merged commit 507f924 into main Nov 15, 2022
@romtsn romtsn deleted the fix/motorola-nil-uuid branch November 15, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants