Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchElementException in CircularFifoQueue when cloning a Scope #2328

Merged
merged 3 commits into from Nov 3, 2022

Conversation

markushi
Copy link
Member

@markushi markushi commented Nov 2, 2022

馃摐 Description

Ensure that the breadcrumbs are copied in a thread safe manner when cloning a Scope.

馃挕 Motivation and Context

This fixes a top crash we saw in the Google Play SDK Console.
Related issues

If you know any better way to test this please let me know! (The test reliably crashed for me until I implemented the fix).

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 336.78 ms 347.98 ms 11.20 ms
Size 1.73 MiB 2.32 MiB 608.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
90e9745 314.68 ms 357.28 ms 42.60 ms

App size

Revision Plain With Sentry Diff
90e9745 1.73 MiB 2.32 MiB 608.63 KiB

Previous results on branch: fix/scope-clone-crashes

Startup times

Revision Plain With Sentry Diff
d5e020a 349.68 ms 383.88 ms 34.20 ms

App size

Revision Plain With Sentry Diff
d5e020a 1.73 MiB 2.32 MiB 608.53 KiB

@romtsn
Copy link
Member

romtsn commented Nov 3, 2022

Nice test 馃憤

@markushi markushi merged commit cc45d5c into main Nov 3, 2022
@markushi markushi deleted the fix/scope-clone-crashes branch November 3, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants