Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Native SDK to v0.5.1 #2306

Merged
merged 1 commit into from Oct 19, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Bumps sentry-android-ndk/sentry-native from 0.5.0 to 0.5.1.

Auto-generated by a dependency updater.

Changelog

0.5.1

Features:

  • Crashpad on Windows now supports fast-fail crashes via a registered Windows Error Reporting (WER) module. (#735)

Fixes:

  • Fix "flush" implementation of winhttp transport. (#763)

Internal:

  • Updated libunwindstack-ndk submodule to 2022-09-16. (#759)
  • Updated Breakpad and Crashpad backends to 2022-09-14. (#735)
  • Be more defensive around transactions (#757)
  • Added a CI timeout for the Android simulator start. (#764)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 17, 2022
@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.5.1 branch from 3c5b8bf to 9582dc5 Compare October 17, 2022 20:28
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 17, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 292.20 ms 336.73 ms 44.53 ms
Size 1.73 MiB 2.32 MiB 607.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2c5f172 310.20 ms 357.16 ms 46.96 ms
3d89dea 345.59 ms 364.06 ms 18.47 ms
4dd88fe 302.12 ms 331.17 ms 29.04 ms
2c5f172 351.18 ms 373.52 ms 22.34 ms
d4087ee 278.00 ms 313.86 ms 35.86 ms
7300956 337.57 ms 384.21 ms 46.64 ms
2f079a1 296.91 ms 337.43 ms 40.51 ms
3d89dea 322.38 ms 350.82 ms 28.45 ms
2c5f172 289.18 ms 307.56 ms 18.38 ms
4ca1d7b 328.46 ms 368.22 ms 39.76 ms

App size

Revision Plain With Sentry Diff
2c5f172 1.73 MiB 2.29 MiB 580.10 KiB
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
4dd88fe 1.73 MiB 2.29 MiB 579.50 KiB
2c5f172 1.73 MiB 2.29 MiB 580.10 KiB
d4087ee 1.73 MiB 2.29 MiB 579.50 KiB
7300956 1.73 MiB 2.29 MiB 578.69 KiB
2f079a1 1.74 MiB 2.33 MiB 605.56 KiB
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
2c5f172 1.73 MiB 2.29 MiB 580.10 KiB
4ca1d7b 1.73 MiB 2.29 MiB 579.88 KiB

Previous results on branch: deps/sentry-android-ndk/sentry-native/0.5.1

Startup times

Revision Plain With Sentry Diff
3d752c3 349.33 ms 364.62 ms 15.29 ms

App size

Revision Plain With Sentry Diff
3d752c3 1.73 MiB 2.32 MiB 607.34 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruno-garcia bruno-garcia force-pushed the deps/sentry-android-ndk/sentry-native/0.5.1 branch from 9582dc5 to ccf13fe Compare October 18, 2022 11:20
@codecov-commenter
Copy link

Codecov Report

Base: 80.12% // Head: 80.12% // No change to project coverage 👍

Coverage data is based on head (ccf13fe) compared to base (221a5df).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2306   +/-   ##
=========================================
  Coverage     80.12%   80.12%           
  Complexity     3435     3435           
=========================================
  Files           242      242           
  Lines         12769    12769           
  Branches       1706     1706           
=========================================
  Hits          10231    10231           
  Misses         1889     1889           
  Partials        649      649           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn merged commit 6b00463 into main Oct 19, 2022
@romtsn romtsn deleted the deps/sentry-android-ndk/sentry-native/0.5.1 branch October 19, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants