Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture event for HTTP requests resulted in server error #2287
Capture event for HTTP requests resulted in server error #2287
Changes from 39 commits
4adc744
371db9a
090a7df
20f8b09
76c4567
a664017
d046806
54cac05
3804a5c
d970ff9
2c113a9
bee4510
1541330
cf81c16
412bc0e
9136b37
2284f88
6268a19
566d70e
9b5e6bb
176e7ef
e896271
67fc1c1
0e27884
a6211b8
2f10f79
a26cde4
d452d9d
d27d2c2
e3bfc1f
c06174f
76168e0
3fd6b01
7572c8a
68408b5
99b62a3
f0a6294
a3ca145
38aeba2
6a4013b
57d3776
636ed7e
b79a165
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be called something like
shouldStatusCodeCauseSentryEvent
or similar?Also should it be extracted into some util so it can be reused from other integrations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so,
isInRange
already can be reused.In case the language has a built-in type for Range instead of
HttpStatusCodeRange
, they will need to implement this anyway.Java does not have Range obj as part of the language.