Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily retrieve HostnameCache in MainEventProcessor #2170

Merged
merged 3 commits into from Jul 14, 2022
Merged

Lazily retrieve HostnameCache in MainEventProcessor #2170

merged 3 commits into from Jul 14, 2022

Conversation

adinauer
Copy link
Member

馃摐 Description

Lazily retrieve HostnameCache in MainEventProcessor as setAttachServerName(false) happens after the MainEventProcessor ctor is called.

馃挕 Motivation and Context

Fixes #2153

馃挌 How did you test it?

Unit Tests

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@adinauer adinauer requested a review from romtsn as a code owner July 13, 2022 09:12
@adinauer adinauer merged commit 8c459df into main Jul 14, 2022
@adinauer adinauer deleted the fix/prevent-anr-by-hostname-cache branch July 14, 2022 08:23
@nienienienie
Copy link

when this will be released?

@vibin vibin mentioned this pull request Aug 3, 2022
Closed
@adinauer
Copy link
Member Author

adinauer commented Aug 3, 2022

@nienienienie it's been released as part of 6.3.0, see https://github.com/getsentry/sentry-java/releases/tag/6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ANR in HostnameCache.updateCache while initialising SDK
3 participants
@adinauer @nienienienie @romtsn