Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send userid in baggage if sendDefaultPii is true #2145

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

userid is considered PII and now hidden behind sendDefaultPii.

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@adinauer adinauer marked this pull request as ready for review June 29, 2022 16:09
@adinauer adinauer requested a review from romtsn as a code owner June 29, 2022 16:09
@adinauer adinauer changed the base branch from main to feat/traces-sampler-into-sample-rate June 29, 2022 16:09
@adinauer
Copy link
Member Author

fyi @brustolin

@bruno-garcia
Copy link
Member

@adinauer Is this really the way to go? this flag guards other PII data so I feel this will stop ppl from using it

@bruno-garcia
Copy link
Member

Sorry closed accidently because CMD + Enter is fucked

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/traces-sampler-into-sample-rate@87f91f8). Click here to learn what that means.
The diff coverage is n/a.

@@                           Coverage Diff                           @@
##             feat/traces-sampler-into-sample-rate    #2145   +/-   ##
=======================================================================
  Coverage                                        ?   80.91%           
  Complexity                                      ?     3289           
=======================================================================
  Files                                           ?      233           
  Lines                                           ?    12054           
  Branches                                        ?     1595           
=======================================================================
  Hits                                            ?     9753           
  Misses                                          ?     1718           
  Partials                                        ?      583           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f91f8...a0a0720. Read the comment docs.

Base automatically changed from feat/traces-sampler-into-sample-rate to feat/add-sample-rate-to-baggage June 30, 2022 10:16
@adinauer
Copy link
Member Author

Closing in favor of #2147 to also skip userId in envelope header trace.

@adinauer adinauer closed this Jun 30, 2022
@romtsn romtsn deleted the feat/skip-userid-in-baggage-if-not-sending-pii branch October 14, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants