-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only send userid in baggage
if sendDefaultPii
is true
#2145
Only send userid in baggage
if sendDefaultPii
is true
#2145
Conversation
fyi @brustolin |
@adinauer Is this really the way to go? this flag guards other PII data so I feel this will stop ppl from using it |
Sorry closed accidently because CMD + Enter is fucked |
…erid-in-baggage-if-not-sending-pii
Codecov Report
@@ Coverage Diff @@
## feat/traces-sampler-into-sample-rate #2145 +/- ##
=======================================================================
Coverage ? 80.91%
Complexity ? 3289
=======================================================================
Files ? 233
Lines ? 12054
Branches ? 1595
=======================================================================
Hits ? 9753
Misses ? 1718
Partials ? 583 Continue to review full report at Codecov.
|
…in-baggage-if-not-sending-pii
Closing in favor of #2147 to also skip |
📜 Description
💡 Motivation and Context
userid
is considered PII and now hidden behindsendDefaultPii
.💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps