Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Jetpack Compose Navigation support #2136

Merged
merged 4 commits into from Jun 29, 2022
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 24, 2022

馃摐 Description

Integration branch to track compose navigation support

馃挕 Motivation and Context

Closes #2096

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

* feat: Add compose module (navigation) (#2121)
* feat: Add compose sample (#2122)
@romtsn romtsn requested a review from adinauer as a code owner June 24, 2022 11:08
@romtsn romtsn marked this pull request as draft June 24, 2022 11:09
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against bcc24c6

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as separate PRs, so approving this as well

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's missing to finish this PR?

@romtsn
Copy link
Member Author

romtsn commented Jun 27, 2022

What's missing to finish this PR?

It's an integration branch for all other PRs (you already reviewed them separately) as mentioned in the description ;) This will have no unreviewed changes apart from a changelog entry when going into main

@romtsn romtsn marked this pull request as ready for review June 29, 2022 11:39
@romtsn romtsn merged commit 524ee49 into main Jun 29, 2022
@romtsn romtsn deleted the feat/compose-navigation-support branch June 29, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Compose Navigation support
3 participants