New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jetpack Compose Navigation support #2136
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed as separate PRs, so approving this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's missing to finish this PR?
...es/sentry-samples-android/src/main/java/io/sentry/samples/android/compose/ComposeActivity.kt
Show resolved
Hide resolved
...es/sentry-samples-android/src/main/java/io/sentry/samples/android/compose/ComposeActivity.kt
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
...ndroid-navigation/src/test/java/io/sentry/android/navigation/SentryNavigationListenerTest.kt
Show resolved
Hide resolved
...ndroid-navigation/src/test/java/io/sentry/android/navigation/SentryNavigationListenerTest.kt
Outdated
Show resolved
Hide resolved
sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryNavigationIntegration.kt
Show resolved
Hide resolved
It's an integration branch for all other PRs (you already reviewed them separately) as mentioned in the description ;) This will have no unreviewed changes apart from a changelog entry when going into main |
馃摐 Description
Integration branch to track compose navigation support
馃挕 Motivation and Context
Closes #2096
馃摑 Checklist