AndroidTransactionProfiler is now initialized the first time a transa… #2009
+86
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
AndroidTransactionProfiler is now initialized the first time a transaction is started, since in the constructor we don't have the options, yet
💡 Motivation and Context
When
AndroidTransactionProfiler
is created and set in the options, in theAndroidOptionsInitializer
, we don't know what options were set throughSentryAndroid.init()
yet, as the profiler is created right before it.We can set the internal variables of the profiler that depends on the options on the first profile, as we would be sure to already have all options set up.
💚 How did you test it?
I'm building some ui tests (that will be released in another pr)
📝 Checklist