Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make App start cold/warm visible to Hybrid SDKs #1848

Merged
merged 2 commits into from Dec 16, 2021
Merged

Fix: Make App start cold/warm visible to Hybrid SDKs #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d53944c
Fix: Make App start cold/warm visible to Hybrid SDKs
marandaneto Dec 16, 2021
4b0ddec
pr id
marandaneto Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@
## Unreleased

* Bump: log4j to 2.16.0 (#1845)
* Fix: Make App start cold/warm visible to Hybrid SDKs (#1848)

## 5.5.0

Expand Down
1 change: 1 addition & 0 deletions sentry-android-core/api/sentry-android-core.api
View file
Open in desktop
Expand Up @@ -34,6 +34,7 @@ public final class io/sentry/android/core/AppLifecycleIntegration : io/sentry/In
}

public final class io/sentry/android/core/AppStartState {
public fun getAppStartInterval ()Ljava/lang/Long;
public fun getAppStartTime ()Ljava/util/Date;
public static fun getInstance ()Lio/sentry/android/core/AppStartState;
public fun isColdStart ()Z
Expand Down
6 changes: 3 additions & 3 deletions sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
View file
Open in desktop
Expand Up @@ -260,7 +260,7 @@ public synchronized void onActivityStarted(final @NonNull Activity activity) {

@Override
public synchronized void onActivityResumed(final @NonNull Activity activity) {
if (!firstActivityResumed && performanceEnabled) {
if (!firstActivityResumed) {

// we only finish the app start if the process is of foregroundImportance
if (foregroundImportance) {
Expand All @@ -277,7 +277,7 @@ public synchronized void onActivityResumed(final @NonNull Activity activity) {
}

// finishes app start span
if (appStartSpan != null) {
if (performanceEnabled && appStartSpan != null) {
appStartSpan.finish();
}
firstActivityResumed = true;
Expand Down Expand Up @@ -355,7 +355,7 @@ ISpan getAppStartSpan() {
}

private void setColdStart(final @Nullable Bundle savedInstanceState) {
if (!firstActivityCreated && performanceEnabled) {
if (!firstActivityCreated) {
// if Activity has savedInstanceState then its a warm start
// https://developer.android.com/topic/performance/vitals/launch-time#warm
AppStartState.getInstance().setColdStart(savedInstanceState == null);
Expand Down
2 changes: 1 addition & 1 deletion sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ void setAppStartEnd(final long appStartEndMillis) {
}

@Nullable
synchronized Long getAppStartInterval() {
public synchronized Long getAppStartInterval() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be public to be used in hybrid SDKs, e.g.
reason is https://github.com/getsentry/sentry-java/blob/main/sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java#L63-L64

if (appStartMillis == null || appStartEndMillis == null) {
return null;
}
Expand Down