Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE while adding "response_body_size" breadcrumb (#1907) #1908

Merged
merged 4 commits into from Feb 24, 2022
Merged

Fix NPE while adding "response_body_size" breadcrumb (#1907) #1908

merged 4 commits into from Feb 24, 2022

Conversation

neseleznev
Copy link
Contributor

馃摐 Description

Closes #1907 , see description there

馃挌 How did you test it?

Tested by researching API of dependency (OpenFeign)

馃摑 Checklist

  • I reviewed the submitted code
  • I didn't add tests, because it requires significant refactoring so that length could be null Integer
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

Codecov Report

Merging #1908 (b4e0206) into main (33bdce3) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1908      +/-   ##
============================================
- Coverage     75.42%   75.42%   -0.01%     
  Complexity     2244     2244              
============================================
  Files           225      225              
  Lines          8026     8025       -1     
  Branches        852      851       -1     
============================================
- Hits           6054     6053       -1     
  Misses         1562     1562              
  Partials        410      410              
Impacted Files Coverage 螖
...in/java/io/sentry/openfeign/SentryFeignClient.java 96.15% <50.00%> (-0.08%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 33bdce3...b4e0206. Read the comment docs.

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@romtsn romtsn merged commit 7e64490 into getsentry:main Feb 24, 2022
@romtsn
Copy link
Member

romtsn commented Feb 24, 2022

Thanks @neseleznev for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in SentryFeignClient
5 participants