Fix NPE while adding "response_body_size" breadcrumb (#1907) (#1908)

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com> Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
getsentry · Feb 24, 2022 · 7e64490 · 7e64490
1 parent 4d43152
commit 7e64490
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Fix: NPE while adding "response_body_size" breadcrumb, when response body length is unknown (#1908)
+
 ## 5.6.2-beta.1
 
 * Fix: Do not include stacktrace frames into Timber message (#1898)

diff --git a/sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java b/sentry-openfeign/src/main/java/io/sentry/openfeign/SentryFeignClient.java
@@ -84,9 +84,8 @@ private void addBreadcrumb(final @NotNull Request request, final @Nullable Respo
             request.httpMethod().name(),
             response != null ? response.status() : null);
     breadcrumb.setData("request_body_size", request.body() != null ? request.body().length : 0);
-    if (response != null) {
-      breadcrumb.setData(
-          "response_body_size", response.body() != null ? response.body().length() : 0);
+    if (response != null && response.body() != null && response.body().length() != null) {
+      breadcrumb.setData("response_body_size", response.body().length());
     }
     hub.addBreadcrumb(breadcrumb);
   }