Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Provide automatic breadcrumbs and transactions for click/scroll event…
…s for Compose (#2390) Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
- Loading branch information
3 people
committed
Dec 14, 2022
1 parent
b5b855d
commit 87598a5
Showing
29 changed files
with
769 additions
and
185 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
...c/main/java/io/sentry/android/core/internal/gestures/AndroidViewGestureTargetLocator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package io.sentry.android.core.internal.gestures; | ||
|
|
||
| import android.content.res.Resources; | ||
| import android.view.View; | ||
| import android.widget.AbsListView; | ||
| import android.widget.ScrollView; | ||
| import androidx.core.view.ScrollingView; | ||
| import io.sentry.internal.gestures.GestureTargetLocator; | ||
| import io.sentry.internal.gestures.UiElement; | ||
| import org.jetbrains.annotations.ApiStatus; | ||
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| @ApiStatus.Internal | ||
| public final class AndroidViewGestureTargetLocator implements GestureTargetLocator { | ||
|
|
||
| private final boolean isAndroidXAvailable; | ||
| private final int[] coordinates = new int[2]; | ||
|
|
||
| public AndroidViewGestureTargetLocator(final boolean isAndroidXAvailable) { | ||
| this.isAndroidXAvailable = isAndroidXAvailable; | ||
| } | ||
|
|
||
| @Override | ||
| public @Nullable UiElement locate( | ||
| @NotNull Object root, float x, float y, UiElement.Type targetType) { | ||
| if (!(root instanceof View)) { | ||
| return null; | ||
| } | ||
| final View view = (View) root; | ||
| if (touchWithinBounds(view, x, y)) { | ||
| if (targetType == UiElement.Type.CLICKABLE && isViewTappable(view)) { | ||
| return createUiElement(view); | ||
| } else if (targetType == UiElement.Type.SCROLLABLE | ||
| && isViewScrollable(view, isAndroidXAvailable)) { | ||
| return createUiElement(view); | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private UiElement createUiElement(final @NotNull View targetView) { | ||
| try { | ||
| final String resourceName = ViewUtils.getResourceId(targetView); | ||
| @Nullable String className = targetView.getClass().getCanonicalName(); | ||
| if (className == null) { | ||
| className = targetView.getClass().getSimpleName(); | ||
| } | ||
| return new UiElement(targetView, className, resourceName, null); | ||
| } catch (Resources.NotFoundException ignored) { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| private boolean touchWithinBounds(final @NotNull View view, final float x, final float y) { | ||
| view.getLocationOnScreen(coordinates); | ||
| int vx = coordinates[0]; | ||
| int vy = coordinates[1]; | ||
|
|
||
| int w = view.getWidth(); | ||
| int h = view.getHeight(); | ||
|
|
||
| return !(x < vx || x > vx + w || y < vy || y > vy + h); | ||
| } | ||
|
|
||
| private static boolean isViewTappable(final @NotNull View view) { | ||
| return view.isClickable() && view.getVisibility() == View.VISIBLE; | ||
| } | ||
|
|
||
| private static boolean isViewScrollable( | ||
| final @NotNull View view, final boolean isAndroidXAvailable) { | ||
| return (isJetpackScrollingView(view, isAndroidXAvailable) | ||
| || AbsListView.class.isAssignableFrom(view.getClass()) | ||
| || ScrollView.class.isAssignableFrom(view.getClass())) | ||
| && view.getVisibility() == View.VISIBLE; | ||
| } | ||
|
|
||
| private static boolean isJetpackScrollingView( | ||
| final @NotNull View view, final boolean isAndroidXAvailable) { | ||
| if (!isAndroidXAvailable) { | ||
| return false; | ||
| } | ||
| return ScrollingView.class.isAssignableFrom(view.getClass()); | ||
| } | ||
| } |
Oops, something went wrong.