-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting of tracing variables #806
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 81.08% 81.29% +0.20%
==========================================
Files 49 49
Lines 4087 4090 +3
==========================================
+ Hits 3314 3325 +11
+ Misses 632 628 -4
+ Partials 141 137 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test case that fails before the code changes are applied.
Perhaps we should also do type checks?
yes, I agree. Maybe move the type cast to the condition.
Perhaps we should also do type checks?