Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of tracing variables #806

Merged
merged 7 commits into from Apr 11, 2024
Merged

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Apr 2, 2024

Perhaps we should also do type checks?

@ribice ribice requested a review from vaind April 2, 2024 07:57
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.29%. Comparing base (9311a06) to head (6607bd0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   81.08%   81.29%   +0.20%     
==========================================
  Files          49       49              
  Lines        4087     4090       +3     
==========================================
+ Hits         3314     3325      +11     
+ Misses        632      628       -4     
+ Partials      141      137       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test case that fails before the code changes are applied.

Perhaps we should also do type checks?

yes, I agree. Maybe move the type cast to the condition.

@ribice ribice requested a review from vaind April 5, 2024 14:02
@cleptric cleptric merged commit 54a39b2 into master Apr 11, 2024
20 checks passed
@cleptric cleptric deleted the fix-tracing-variable-setting branch April 11, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants