Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddFailureIssueThreshold & RecoveryThreshold to MonitorConfig #775

Merged
merged 3 commits into from Apr 16, 2024

Conversation

cleptric
Copy link
Member

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (bf970d1) to head (3c494c1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          49       49           
  Lines        4190     4190           
=======================================
  Hits         3481     3481           
  Misses        567      567           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antonpirker
Copy link
Member

Maybe add a test where those parameters are omitted?

check_in.go Show resolved Hide resolved
@cleptric cleptric enabled auto-merge (squash) April 16, 2024 09:42
@cleptric cleptric merged commit 7954115 into master Apr 16, 2024
20 checks passed
@cleptric cleptric deleted the crons-upserts branch April 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants