Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: improve flaky tests #744

Merged
merged 2 commits into from Nov 4, 2023
Merged

ci: improve flaky tests #744

merged 2 commits into from Nov 4, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 2, 2023 •
edited

Some tests are flaky if the machine is overloaded - some goroutines may not get captured consistently on all ticks. And since we cannot control the number of goroutines running (HTTP workers from other tests hang around indefinitely, see #731). Disabling the flaky test in CI when race detection is on. We can enable it once #731 is fixed.

The other flaky test I'm not sure about so just adding logs and maybe it would hep figure out what's wrong:

--- FAIL: TestProfilerPanicOnTick (0.00s)
    profiler_test.go:339: 
        	Error Trace:	/home/runner/work/sentry-go/sentry-go/profiler_test.go:339
        	            				/home/runner/work/sentry-go/sentry-go/profiler_test.go:263
        	Error:      	Should NOT be empty, but was 
        	Test:       	TestProfilerPanicOnTick

#skip-changelog

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
internal/testutils/race.go 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@vaind vaind marked this pull request as ready for review November 2, 2023 18:08
@vaind vaind requested a review from cleptric November 2, 2023 18:10
greywolve
greywolve reviewed Nov 4, 2023
View reviewed changes
profiler_test.go Outdated Show resolved Hide resolved
greywolve
greywolve approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@greywolve greywolve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaind @greywolve
Update profiler_test.go
412980f 
Co-authored-by: Oliver Powell <oliver@opowell.com>
@vaind vaind merged commit 03c6345 into master Nov 4, 2023
17 checks passed
@vaind vaind deleted the ci/improve-flaky-tests branch November 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greywolve greywolve greywolve approved these changes

@cleptric cleptric Awaiting requested review from cleptric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaind @greywolve